Implement ＠defer "June 2023" response format #6331
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyConfiguration{
"repoOverrides": {
"apollographql/apollo-kotlin@main": {
"remote": {
"owner": "apollographql",
"repo": "apollo-kotlin",
"branch": "defer-incremental-response-format-june-2023"
}
}
}
}
1 pages published. Build will be available for 30 days. |
BoD
force-pushed
the
defer-incremental-response-format-june-2023
branch
from
e2da859 to
bb504f6
Compare
❌ Docs preview failedThe preview failed to build. Build ID: 863b45d1dd5964c1247288c5 ErrorsGeneral: fetch failed |
BoD
force-pushed
the
defer-incremental-response-format-june-2023
branch
from
bb504f6 to
e1ee642
Compare
…gmentIdentifier -> IncrementalResultIdentifier
BoD
force-pushed
the
defer-incremental-response-format-june-2023
branch
from
e1ee642 to
4fa99ad
Compare
|
Apollo Client 4 introduces different handlers for different incremental formats. We could do the same while the format iterates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the latest (as of 2024-12-17) ＠defer incremental response format as seen in examples and spec edits.
This shouldn't be merged as-is, as at least the end-to-end tests with the Router will fail.
There may be a way to have both the "old" (
20220824) and latest formats working but not sure this would be useful.